CRM-21124 fix error on cacheKey when too long #10921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickadoo
reviewed
Aug 30, 2017
| @@ -1914,7 +1914,7 @@ public static function getMergeCacheKeyString($rule_group_id, $group_id, $criter | |||
| $cacheKeyString = "merge {$contactType}"; | |||
| $cacheKeyString .= $rule_group_id ? "_{$rule_group_id}" : '_0'; | |||
| $cacheKeyString .= $group_id ? "_{$group_id}" : '_0'; | |||
| $cacheKeyString .= !empty($criteria) ? serialize($criteria) : '_0'; | |||
| $cacheKeyString .= !empty($criteria) ? md5(serialize($criteria)) : '_0'; | |||
There was a problem hiding this comment.
Probably a silly question, but from the description it looks like this key is stored in the database. When upgrading to the next version will the cache always be cleared? It would probably be harmless to have the old version of the cache key still in the database anyway, but just thought I'd check.
There was a problem hiding this comment.
I think upgrades do clear these out, or you can schedule a job to intermittently clear cache tables.
This is the sort of cache that just gets regenerated if empty. I can't see any risks on there being extraneous or missing entries
mickadoo
approved these changes
Aug 31, 2017
|
Make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a rare DB error when merging with a long criteria string, which exceeds the field length
Before
Fatal error when calling the batchMerge with a long critieria string (hard to do outside of code or api calls)
After
No fatal error
Technical Details
By passing criteria through md5() we can ensure it is no longer than 32 char